From d412ebf6feea74cdd5ff02a7921b1d4807c2c983 Mon Sep 17 00:00:00 2001
From: Juuso Lapinlampi wub@partyvan.eu Date: Tue, 29 Dec 2015 04:34:38 +0000 Subject: [PATCH 1/1] s_err.c: Standardize 256 (RPL_ADMINME) with RFC 1459
RPL_ADMINME is a response the client receives using the ADMIN command. Bahamut used to implement a non-standard version of this.
The RFC 1459 standard [1] says in section "6.2 Command responses.":
256 RPL_ADMINME "<server> :Administrative info"
This commit corrects the behavior to follow the standard.
[1]: https://tools.ietf.org/html/rfc1459 --- src/s_err.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/s_err.c b/src/s_err.c index 075e172..073a7ba 100644 --- a/src/s_err.c +++ b/src/s_err.c @@ -280,7 +280,7 @@ static char *replies[] = /* 253 RPL_LUSERUNKNOWN */ ":%s 253 %s %d :unknown connection(s)", /* 254 RPL_LUSERCHANNELS */ ":%s 254 %s %d :channels formed", /* 255 RPL_LUSERME */ ":%s 255 %s :I have %d clients and %d servers", - /* 256 RPL_ADMINME */ ":%s 256 %s :Administrative info about %s", + /* 256 RPL_ADMINME */ ":%s 256 %s %s :Administrative info", /* 257 RPL_ADMINLOC1 */ ":%s 257 %s :%s", /* 258 RPL_ADMINLOC2 */ ":%s 258 %s :%s", /* 259 RPL_ADMINEMAIL */ ":%s 259 %s :%s",
Thanks Juuso - beyond the RFC issue, have you run into any cases of this causing problems with clients?
-Aaron
On Tue, Dec 29, 2015 at 12:40 AM, Juuso Lapinlampi wub@partyvan.eu wrote:
From d412ebf6feea74cdd5ff02a7921b1d4807c2c983 Mon Sep 17 00:00:00 2001
From: Juuso Lapinlampi wub@partyvan.eu Date: Tue, 29 Dec 2015 04:34:38 +0000 Subject: [PATCH 1/1] s_err.c: Standardize 256 (RPL_ADMINME) with RFC 1459
RPL_ADMINME is a response the client receives using the ADMIN command. Bahamut used to implement a non-standard version of this.
The RFC 1459 standard [1] says in section "6.2 Command responses.":
256 RPL_ADMINME "<server> :Administrative info"This commit corrects the behavior to follow the standard.
[1]: https://tools.ietf.org/html/rfc1459
src/s_err.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/s_err.c b/src/s_err.c index 075e172..073a7ba 100644 --- a/src/s_err.c +++ b/src/s_err.c @@ -280,7 +280,7 @@ static char *replies[] = /* 253 RPL_LUSERUNKNOWN */ ":%s 253 %s %d :unknown connection(s)", /* 254 RPL_LUSERCHANNELS */ ":%s 254 %s %d :channels formed", /* 255 RPL_LUSERME */ ":%s 255 %s :I have %d clients and %d servers",
- /* 256 RPL_ADMINME */ ":%s 256 %s :Administrative info about %s",
- /* 256 RPL_ADMINME */ ":%s 256 %s %s :Administrative info", /* 257 RPL_ADMINLOC1 */ ":%s 257 %s :%s", /* 258 RPL_ADMINLOC2 */ ":%s 258 %s :%s", /* 259 RPL_ADMINEMAIL */ ":%s 259 %s :%s",
-- 2.6.4
DALnet-src mailing list DALnet-src@lists.dal.net https://lists.dal.net/mailman/listinfo/dalnet-src
-
Aaron Wiebe -
Juuso Lapinlampi