Back on June I had reported a problem with the function "initconf" from "src/confparse.c" This function basically calls fopen but never bothers to call fclose regardless whether the function was successful or not. I've attached the original message that I had sent that describes the problem in more detail, as well as a git formatted patch with the latest git repository to fix this. It may not seem as a problem, but this bug eventually caught up to our server; it made the IRCd incapable of accepting any new connections whatsoever. The fix is really simple, just call fclose() before every closing statement on the function. This bug still persists on bahamut 1.8.9. Sincerely, Juan Baez.
Thanks for the follow-up Juan, I'm not sure how I missed this one. Your commit is now in the mainline as a575ed98687c720dab9f7160bfd7fb50a9222579. It will be in the next release. Thanks again, -epiphani On Thu, Aug 19, 2010 at 2:36 PM, Juan Baez <tux@solid-ircd.com> wrote:
Back on June I had reported a problem with the function “initconf” from “src/confparse.c”
This function basically calls fopen but never bothers to call fclose regardless whether the function was successful or not. I’ve attached the original message that I had sent that describes the problem in more detail, as well as a git formatted patch with the latest git repository to fix this. It may not seem as a problem, but this bug eventually caught up to our server; it made the IRCd incapable of accepting any new connections whatsoever.
The fix is really simple, just call fclose() before every closing statement on the function. This bug still persists on bahamut 1.8.9.
Sincerely,
Juan Baez.
_______________________________________________ DALnet-src mailing list DALnet-src@lists.dal.net https://lists.dal.net/mailman/listinfo/dalnet-src
participants (2)
-
Aaron Wiebe -
Juan Baez