On Fri, Apr 24, 2009 at 09:10:20AM -0400, epiphani wrote:
If a normal NICK doesn't update the banserial, how does bsilent currently work on a nick change? With the current SVSNICK method of sending the change to the users' server and having the nick change propagate out to the rest of the network as a NICK, does that create a desync in what servers think the user can speak on the change?
Currently, without the patch, there shouldn't be a desync happening because every server will have the same idea of the users' cached ban status afterwards. The status they had before the SVSNICK occurred is what is used, and the users' server forbids a nick change or any talking according to that status, which matches what the rest of the network believes. With the patch and without NICK being fixed to update the banserial (which an addition to the patch could do), we create a desync as the users' server may have a different idea of what the user can do than the rest of the network. The goal is for every server to have the cached ban status reflect the new actual ban status for the user after the SVSNICK is finished.
You're on the right track here though. One request about your patch - can you use git? If you pull down our git tree and send a git formatted patch, I can properly attribute the fix to you in the commit history. The git tree is at http://code.dal.net/bahamut.git
Sure, I can send a git formatted patch to you (or to the list as well.) -- Ned T. Crigler