Good conversation on this one - this would be something good to get fixed. A few comments on the thread so far... On Thu, Apr 23, 2009 at 8:12 PM, Ned T. Crigler <crigler@gmail.com> wrote:
With my patch so far, only the user's local server will have the correct cached ban information, while all other servers on the network will still have the old cached ban information. This means, for example, when someone is SVSNICKed from a banned nickname to a unbanned nickname (bannednick to Guest12345 for instance), only their local server will believe that they are now unbanned.
If a normal NICK doesn't update the banserial, how does bsilent currently work on a nick change? With the current SVSNICK method of sending the change to the users' server and having the nick change propagate out to the rest of the network as a NICK, does that create a desync in what servers think the user can speak on the change? You're on the right track here though. One request about your patch - can you use git? If you pull down our git tree and send a git formatted patch, I can properly attribute the fix to you in the commit history. The git tree is at http://code.dal.net/bahamut.git This goes for any patches that are submitted. I'll definitely review anything that goes through this list, but having the patches git-formatted will make attribution and tracking easier. Thanks! -epi