- DALnet-src - nomad.dal.net

[PATCH] Fix safe_ssl_read/safe_ssl_write to return -1 for EWOULDBLOCK/EAGAIN.
by Ned T. Crigler 17 May '10

17 May '10

The safe_ssl_read and safe_ssl_write functions were setting errno and then returning 0, which is incorrect. They should be returning -1 instead, since proper code only checks errno when -1 is returned from a system call. This patch should hopefully fix a bug that was causing SSL users to be disconnected when a large number of bytes were being transferred from or to the IRC server. --- src/ssl.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ssl.c b/src/ssl.c index dab194c..7f688ce 100644 --- a/src/ssl.c +++ b/src/ssl.c @@ -162,11 +162,11 @@ int safe_ssl_read(aClient *acptr, void *buf, int sz) { case SSL_ERROR_WANT_READ: errno = EWOULDBLOCK; - return 0; + return -1; } case SSL_ERROR_SSL: if(errno == EAGAIN) - return 0; + return -1; default: return fatal_ssl_error(ssl_err, SAFE_SSL_READ, acptr); } @@ -190,11 +190,11 @@ int safe_ssl_write(aClient *acptr, const void *buf, int sz) case SSL_ERROR_WANT_WRITE: case SSL_ERROR_WANT_READ: errno = EWOULDBLOCK; - return 0; + return -1; } case SSL_ERROR_SSL: if(errno == EAGAIN) - return 0; + return -1; default: return fatal_ssl_error(ssl_err, SAFE_SSL_WRITE, acptr); } -- 1.7.1

1 0

Re: [DALnet-services] Bug in (ChanServ)
by zapp 16 May '10

16 May '10

Mr Key the command you mention for nick ban (nick!*@*) is only work when User Join the channel with same nick. -ChanServ- allow User's to come with different nick and after join the channel -ChanServ- is not going to verify akick User's (Added in akick List) to kick them out from the channel. akicked nick's still allow in the channel coz bot auto unban the list of +b User's. They are able to join the channel with different nick and after join the channel they are able to set that akick nick ( Added in akick list). -ChanServ- Should Ban akick User's, Does'nt matter If User change his/her nick after joining the channel or before join the channel. So i am not agree with you. And still its a bug for me. And Mr Vin king, Dalnet allow Us to identified with nick, there is no INTERNET PROTOCOL RESTRICTION (IPR), We are allow to identified nick's with any ip/hostmask. So no way to add host in the akick list instead of nicks.Our identity is nick not hostmask. Yes i added host/mask too but rarely. when i see that user continuosly flood Abuse with same ip/mask. I already Discussed it with Dalnet staff regarding Host/Masking coz of continuosly nuking. Will see what happen. On 5/13/10, key <key(a)theirc.net> wrote: > > What you’re referring to is not a bug. The command is working as > designed. Adding an akick by nick works on identified users only, and only > on join. If you want to akick the nick regardless of identification, you can > use nick!*@*. If you want the user to be kicked after identifying post-join, > that is an enhancement request, not a bug. > > > > -key > > > > *From:* dalnet-src-bounces(a)lists.dal.net [mailto: > dalnet-src-bounces(a)lists.dal.net] *On Behalf Of *zapp > *Sent:* Wednesday, May 12, 2010 5:40 PM > *To:* Vin King > *Cc:* Yoba(a)dal.net; dalnet-src(a)dal.net; dalnet-services(a)dal.net > *Subject:* Re: [DALnet-src] Bug in (ChanServ) > > > > Dalnet is allow to register nick not host/mask. So why i just put IP/HOST > in akick instead of nick . They Use proxy Servers , Some ip mask change in C > range B range so i am not going to discuss about ip/mask i am just asking > about nick. If nick is in akick and the User joined with same > nick. -ChanServ- should ban him/her . > > + after identified(CONFIRMED THAT HE OWNS THE NICK) still ChanServ allow > that User on channel. So its a bug. Read my previous email carefuly i > already mention that After confirmed(IDENTIFIED), -ChanServ- Allow him > to stay on my channel > > On 5/13/10, *Vin King* <vin.king(a)gmail.com> wrote: > > If you akick the hostmask of the user instead of their registered nick, > then they would be akicked regardless of if they identify to a nick or not. > > Take into consideration that if someone on dialup has a registered nick, > and does not identify to it the next time they connect. Their IP address > would be different than the last time they connected, and ChanServ wouldn't > be able to identify them as the registered nick owner. > > When you add just a registered nick to akick it can only akick if it > confirms that the person in question owns the nick. If you akick based on > hostmask, it won't matter. > > On Wed, May 12, 2010 at 5:00 PM, zapp <zapp(a)channelpakistan.net> wrote: > > Hello Again, > Today i am here to tell you people that there is a bug in > -ChanServ- . I am the Sop on #Pakistan and today when i just add User in > akick list. -ChanServ- allow him to join my channel because the User was'nt > identified While joined the channel. After Joined the channel he identified > his nick and chat like a simple user. ChanServ allow him on Channel. It > does'nt matter User is identified or not Chanserv should akick him/her > identified or without identified or atleast identified. So i just consider > it as a bug and Discuss it with Kobi_S. He also consider it as a bug. > > Hope you people look into it. > > Regards > -- > Official #Pakistan Admin > zapp > _______________________________________________ > DALnet-src mailing list > DALnet-src(a)lists.dal.net > https://lists.dal.net/mailman/listinfo/dalnet-src > > > > > > > -- > Official #Pakistan Admin > zapp > -- Official #Pakistan Admin zapp

3 2

Bug in (ChanServ)
by zapp 12 May '10

12 May '10

Hello Again, Today i am here to tell you people that there is a bug in -ChanServ- . I am the Sop on #Pakistan and today when i just add User in akick list. -ChanServ- allow him to join my channel because the User was'nt identified While joined the channel. After Joined the channel he identified his nick and chat like a simple user. ChanServ allow him on Channel. It does'nt matter User is identified or not Chanserv should akick him/her identified or without identified or atleast identified. So i just consider it as a bug and Discuss it with Kobi_S. He also consider it as a bug. Hope you people look into it. Regards -- Official #Pakistan Admin zapp

2 3

Host/Masking!!!
by zapp 08 May '10

08 May '10

Hello all, Tue Oct 13 16:50:20 PDT 2009 - Kobi_S discussed here about host/masking for dalnet user's. But its May 2010 and i dont think so you people are thinking about it. Dalnet is the bigest IRC server. And you people should think about the idea of Kobi_S .Its really hard to hide ip/mask . But easy to nuke anyone.We dont trust shell companies for psybnc due to password protection. The purpose to send this email is to remind you that please think about it. -- Official #Pakistan Admin zapp

2 1

Error when I use Make !
by nicolas pottier 06 May '10

06 May '10

Hello I have this issue when I trying to make ! merci:/var/www/bahamut-1.8.8# makeBuilding srcmake[1]: entrant dans le répertoire « /var/www/bahamut-1.8.8/src »gcc -g -O2 -Wall -fno-strict-aliasing -I../include -c blalloc.cIn file included from blalloc.c:9:../include/struct.h:52:51: error: openssl/rsa.h: Aucun fichier ou répertoire de ce type../include/struct.h:53:28: error: openssl/crypto.h: Aucun fichier ou répertoire de ce type../include/struct.h:54:26: error: openssl/x509.h: Aucun fichier ou répertoire de ce type../include/struct.h:55:25: error: openssl/pem.h: Aucun fichier ou répertoire de ce type../include/struct.h:56:25: error: openssl/ssl.h: Aucun fichier ou répertoire de ce type../include/struct.h:57:25: error: openssl/err.h: Aucun fichier ou répertoire de ce typeIn file included from blalloc.c:9:../include/struct.h:804: error: expected specifier-qualifier-list before ‘SSL’../include/struct.h:1011: error: expected specifier-qualifier-list before ‘SSL’In file included from blalloc.c:12:../include/h.h:383: error: expected ‘)’ before ‘*’ tokenmake[1]: *** [blalloc.o] Erreur 1make[1]: quittant le répertoire « /var/www/bahamut-1.8.8/src »Building docmake[1]: entrant dans le répertoire « /var/www/bahamut-1.8.8/doc »make[1]: Rien à faire pour « build ».make[1]: quittant le répertoire « /var/www/bahamut-1.8.8/doc »Building toolsmake[1]: entrant dans le répertoire « /var/www/bahamut-1.8.8/tools »gcc -I../include -c mkpasswd.cgcc -o mkpasswd mkpasswd.o -lz -ldl -lcrypt -lresolv -lnsl -Wl,-export-dynamicgcc -I../include -c convert_conf.cIn file included from convert_conf.c:20:../include/struct.h:52:51: error: openssl/rsa.h: Aucun fichier ou répertoire de ce type../include/struct.h:53:28: error: openssl/crypto.h: Aucun fichier ou répertoire de ce type../include/struct.h:54:26: error: openssl/x509.h: Aucun fichier ou répertoire de ce type../include/struct.h:55:25: error: openssl/pem.h: Aucun fichier ou répertoire de ce type../include/struct.h:56:25: error: openssl/ssl.h: Aucun fichier ou répertoire de ce type../include/struct.h:57:25: error: openssl/err.h: Aucun fichier ou répertoire de ce typeIn file included from convert_conf.c:20:../include/struct.h:804: error: expected specifier-qualifier-list before ‘SSL’../include/struct.h:1011: error: expected specifier-qualifier-list before ‘SSL’make[1]: *** [convert_conf.o] Erreur 1make[1]: quittant le répertoire « /var/www/bahamut-1.8.8/tools »******************************************************************************* For help with bahamut, please refer to http://bahamut.dal.net/ ** If you encouter serious security related bugs, please mail coders(a)dal.net ** For other bug reports and inquiries, please mail dalnet-src(a)dal.net ** Thank you for choosing Bahamut! - The DALnet coding team ******************************************************************************* _________________________________________________________________ Découvrez comment SURFER DISCRETEMENT sur un site de rencontres ! http://clk.atdmt.com/FRM/go/206608211/direct/01/

1 0

Bahamut 1.8.8
by Aaron Wiebe 04 May '10

04 May '10

I just released Bahamut 1.8.8 to fix a few issues that presented quckly in 1.8.7 - specifically: - one case of user-triggered crash with a null-pointer dereference in dccallow code - an installation issue on freebsd with sed Sorry for the confusion and please use the new version. -epi

1 0

Bahamut 1.8.7
by Aaron Wiebe 04 May '10

04 May '10

Greetings All, The coding team is proud to announce the release of Bahamut 1.8.7. Most notably, this release provides client-side support for SSL connections, and numerous small fixes and updates. This release is considered a "slow deployment" release, due to some of the changes involved. DALnet Admins are free to roll out this update, but at this time there is no mandatory upgrade schedule. One will likely be announced in several weeks. The intention is to have slow growth of deployment base in order to come to an understanding of impact of SSL and other options to the behavior of the network. The new tarball can be downloaded at http://code.dal.net/release/bahamut-1.8.7.tar.gz Thank you to Kobi and Ned for their contributions. The following changes have been made in summary: Kobi Shmueli (19): Added SSL initialization and rehashing stuff Added the needed changes for SSL to acutally work Added flags support for the port block and mark SSL users with SSL on the umode +c notice Added make-cert.sh & make-cert.cnf to create the server certificate Added SSL umode/cmode/flag Let users/opers message +o users even if the sender is +R Fixed NO_USER_STATS to allow /stats from u:lined servers Rakarra's opernick patch typo (UNKINE --> UNKLINE) Let server admins set a maxrecvq per class block (take #2) Added SVSPANIC (Stops users from sending commands to services). Make kill -HUP remove all throttles. Added umode +C Re-added CHANKILL from the old 1.8.4-trunk (I think Quension wrote it). Changed SVSHOLD to support channels. Let SVSCLONE override local clone limits too. Let services change hosts (take #5) dccallow fix Re-added the SERVICESHUB sutff with conf flags Ned T. Crigler (2): Force the cached banserial of a user to be updated on a SVSNICK. Remove the use of ircsprintf. epiphani (6): Update docs to reflect SSL configuration support Move make-cert tools into the tools directory Fix up some templating and configure script stuff to make SSL tools install cleanly Allow port definitions that do not perform DNS or ident checks. Update notifcations for failed OPER attempts Update TODO and Patchlevel. This is 1.8.7.

1 0

usermod and spam
by Yoba＠DAL.net 21 Mar '10

21 Mar '10

Hello, I got the idea, if possible, implementing some features to bahamut, for users to deal with spam. The idea is, adding a user mode, if enabled, all incoming msg with the pattern http* and www* will be blocked, if the sender is unregistered, Since most of spam I've seen, spam bots, are unregistered, so, registered users can override the mode. thanks

2 2

Bahamut FHS
by Bennie Joubert 16 Feb '10

16 Feb '10

Hi After satisfying the ssl dependency the .irc.entropy file also popped up. The new diff file: diff -rupN bahamut-1.8.6.orig/include/config.h bahamut-1.8.6/include/config.h --- bahamut-1.8.6.orig/include/config.h 2008-10-10 19:52:21.000000000 +0200 +++ bahamut-1.8.6/include/config.h 2010-02-16 09:38:36.000000000 +0200 @@ -134,11 +134,13 @@ /* File names * the server will look for these files */ -#define MPATH "ircd.motd" -#define SMPATH "ircd.smotd" -#define LPATH "ircd.log" -#define PPATH "ircd.pid" -#define HPATH "opers.txt" +#define ETCDIR "/etc/ircd" +#define RUNDIR "/var/run/ircd" +#define MPATH ETCDIR "/ircd.motd" +#define SMPATH ETCDIR "ircd.smotd" +#define LPATH "/var/log/ircd/ircd.log" +#define PPATH RUNDIR "/ircd.pid" +#define HPATH ETCDIR "/opers.txt" /* Services Definitions */ diff -rupN bahamut-1.8.6.orig/src/dh.c bahamut-1.8.6/src/dh.c --- bahamut-1.8.6.orig/src/dh.c 2009-03-01 21:23:59.000000000 +0200 +++ bahamut-1.8.6/src/dh.c 2010-02-16 09:43:49.000000000 +0200 @@ -117,7 +117,7 @@ static inline void entropy_error(void) RAND_SRC, strerror(errno)); printf("ircd needs a %d byte random seed.\n", RAND_BYTES); printf("You can place a file containing random data called" - " .ircd.entropy\nin the directory with your ircd.conf." + " .ircd.entropy\nin the directory /var/lib/ircd." " This file must be at least %d bytes\n", RAND_BYTES); printf("long and should be suitably random.\n"); } @@ -171,10 +171,10 @@ static int make_entropy() printf("Done.\n"); fclose(fp); - fp = fopen(".ircd.entropy", "w"); + fp = fopen("/var/lib/ircd/.ircd.entropy", "w"); if(!fp) { - printf("Could not open .ircd.entropy for writing: %s\n", + printf("Could not open /var/lib/ircd/.ircd.entropy for writing: %s\n", strerror(errno)); return 0; } @@ -182,7 +182,7 @@ static int make_entropy() fwrite(randbuf, RAND_BYTES * 4, 1, fp); fclose(fp); - RAND_load_file(".ircd.entropy", -1); + RAND_load_file("/var/lib/ircd/.ircd.entropy", -1); return 1; } @@ -192,7 +192,7 @@ static int init_random() int ret; time_t now; - ret = RAND_load_file(".ircd.entropy", -1); + ret = RAND_load_file("/var/lib/ircd/.ircd.entropy", -1); if(ret <= 0) { if(!make_entropy()) @@ -206,7 +206,7 @@ static int init_random() /* this is probably not too good, but it saves just writing the whole state back to disk with no changes. */ RAND_seed(&now, 4); - RAND_write_file(".ircd.entropy"); + RAND_write_file("/var/lib/ircd/.ircd.entropy"); return 0; } diff -rupN bahamut-1.8.6.orig/src/ircd.c bahamut-1.8.6/src/ircd.c --- bahamut-1.8.6.orig/src/ircd.c 2009-03-04 04:11:01.000000000 +0200 +++ bahamut-1.8.6/src/ircd.c 2010-02-16 09:38:36.000000000 +0200 @@ -172,7 +172,7 @@ void s_die() #ifdef USE_SYSLOG (void) syslog(LOG_CRIT, "Server killed By SIGTERM"); #endif - ircsprintf(tmp, "%s/.maxclients", dpath); + ircsprintf(tmp, "/var/lib/ircd/.maxclients", dpath); fp=fopen(tmp, "w"); if(fp!=NULL) { @@ -769,7 +769,7 @@ main(int argc, char *argv[]) exit(0); } - ircsprintf(tmp, "%s/.maxclients", dpath); + ircsprintf(tmp, "/var/lib/ircd/.maxclients", dpath); mcsfp = fopen(tmp, "r"); if(mcsfp != NULL) { diff -rupN bahamut-1.8.6.orig/src/klines.c bahamut-1.8.6/src/klines.c --- bahamut-1.8.6.orig/src/klines.c 2008-10-10 19:52:21.000000000 +0200 +++ bahamut-1.8.6/src/klines.c 2010-02-16 09:38:36.000000000 +0200 @@ -471,7 +471,7 @@ klinestore_compact(void) journalcount = 0; /* open a compaction file to dump all active klines to */ - ircsnprintf(buf1, sizeof(buf1), "%s/.klines_c", dpath); + ircsnprintf(buf1, sizeof(buf1), "/var/lib/ircd/.klines_c", dpath); newfile = open(buf1, O_WRONLY|O_CREAT|O_TRUNC, 0700); if (newfile < 0) { @@ -548,7 +548,7 @@ klinestore_init(int noreload) char buf1[1024]; FILE *jf; - ircsnprintf(journalfilename, sizeof(journalfilename), "%s/.klines", dpath); + ircsnprintf(journalfilename, sizeof(journalfilename), "/var/lib/ircd/.klines", dpath); if (journal >= 0) { diff -rupN bahamut-1.8.6.orig/src/s_serv.c bahamut-1.8.6/src/s_serv.c --- bahamut-1.8.6.orig/src/s_serv.c 2008-10-10 20:27:25.000000000 +0200 +++ bahamut-1.8.6/src/s_serv.c 2010-02-16 09:38:36.000000000 +0200 @@ -809,7 +809,7 @@ int send_lusers(aClient *cptr, aClient * char tmp[PATH_MAX]; last_stat_save = timeofday; - ircsprintf(tmp, "%s/.maxclients", dpath); + ircsprintf(tmp, "/var/lib/ircd/.maxclients", dpath); fp = fopen(tmp, "w"); if (fp != NULL) { Kind Regards, Bennie

2 3

Bahamut FHS
by Bennie Joubert 15 Feb '10

15 Feb '10

Hi Is there an option that I can use during the build to make bahamut more fhs compliant and if not can you just point in a direction to create a patch to make it fhs compliant? (Are all the file and directory options contained in a file?) Here is what I have already: diff -rupN bahamut-1.8.6.orig/include/config.h bahamut-1.8.6/include/config.h --- bahamut-1.8.6.orig/include/config.h 2008-10-10 19:52:21.000000000 +0200 +++ bahamut-1.8.6/include/config.h 2010-02-15 10:26:38.000000000 +0200 @@ -134,11 +134,13 @@ /* File names * the server will look for these files */ -#define MPATH "ircd.motd" -#define SMPATH "ircd.smotd" -#define LPATH "ircd.log" -#define PPATH "ircd.pid" -#define HPATH "opers.txt" +#define ETCDIR "/etc/ircd" +#define RUNDIR "/var/run/ircd" +#define MPATH ETCDIR "/ircd.motd" +#define SMPATH ETCDIR "ircd.smotd" +#define LPATH "/var/log/ircd/ircd.log" +#define PPATH RUNDIR "/ircd.pid" +#define HPATH ETCDIR "/opers.txt" /* Services Definitions */ diff -rupN bahamut-1.8.6.orig/src/ircd.c bahamut-1.8.6/src/ircd.c --- bahamut-1.8.6.orig/src/ircd.c 2009-03-04 04:11:01.000000000 +0200 +++ bahamut-1.8.6/src/ircd.c 2010-02-15 10:26:22.000000000 +0200 @@ -172,7 +172,7 @@ void s_die() #ifdef USE_SYSLOG (void) syslog(LOG_CRIT, "Server killed By SIGTERM"); #endif - ircsprintf(tmp, "%s/.maxclients", dpath); + ircsprintf(tmp, "/var/lib/ircd/.maxclients", dpath); fp=fopen(tmp, "w"); if(fp!=NULL) { @@ -769,7 +769,7 @@ main(int argc, char *argv[]) exit(0); } - ircsprintf(tmp, "%s/.maxclients", dpath); + ircsprintf(tmp, "/var/lib/ircd/.maxclients", dpath); mcsfp = fopen(tmp, "r"); if(mcsfp != NULL) { diff -rupN bahamut-1.8.6.orig/src/klines.c bahamut-1.8.6/src/klines.c --- bahamut-1.8.6.orig/src/klines.c 2008-10-10 19:52:21.000000000 +0200 +++ bahamut-1.8.6/src/klines.c 2010-02-15 10:26:22.000000000 +0200 @@ -471,7 +471,7 @@ klinestore_compact(void) journalcount = 0; /* open a compaction file to dump all active klines to */ - ircsnprintf(buf1, sizeof(buf1), "%s/.klines_c", dpath); + ircsnprintf(buf1, sizeof(buf1), "/var/lib/ircd/.klines_c", dpath); newfile = open(buf1, O_WRONLY|O_CREAT|O_TRUNC, 0700); if (newfile < 0) { @@ -548,7 +548,7 @@ klinestore_init(int noreload) char buf1[1024]; FILE *jf; - ircsnprintf(journalfilename, sizeof(journalfilename), "%s/.klines", dpath); + ircsnprintf(journalfilename, sizeof(journalfilename), "/var/lib/ircd/.klines", dpath); if (journal >= 0) { diff -rupN bahamut-1.8.6.orig/src/s_serv.c bahamut-1.8.6/src/s_serv.c --- bahamut-1.8.6.orig/src/s_serv.c 2008-10-10 20:27:25.000000000 +0200 +++ bahamut-1.8.6/src/s_serv.c 2010-02-15 10:26:22.000000000 +0200 @@ -809,7 +809,7 @@ int send_lusers(aClient *cptr, aClient * char tmp[PATH_MAX]; last_stat_save = timeofday; - ircsprintf(tmp, "%s/.maxclients", dpath); + ircsprintf(tmp, "/var/lib/ircd/.maxclients", dpath); fp = fopen(tmp, "w"); if (fp != NULL) { Kind Regards, Bennie

1 0