July 2011 - DALnet-src - nomad.dal.net

Channel Mode Suggestion
by Sukvinderjit singh 22 Jul '11

22 Jul '11

Hello Sir/Madam, As an old user on Dalnet i would like to suggest a mode that will work along with +j mode to stop flood effectively.As we all know +j controls the joins in a channel according to its setting. I would like to suggest another mode which would be called +Q or +q. What is +Q or +q ? Basically it will stops a user from speaking/noticing/action on the channel upon joining.Let me explain further : ie /mode channel +q:10 <-- a user cant chat/notice/action on the channel for 10 secs upon joining. This will stop the Message/notice/code Flood Such Like : [14:08] * Joins: cinrgt (~erzf(a)218.22.225.175) [14:08] -cinrgt:#india- #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA [14:08] * Joins: hprhou (~dxjz(a)218.22.225.175) [14:08] * Joins: pieynm (~znir(a)ool-182cce21.dyn.optonline.net) [14:08] -pieynm:#india- #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA #BESTOFINDIA As you can see from the above example +j is a great mode,it reduces mass join but it doesnt stops message flood upon joining.With the combination of +j and +q it will work wonders and i believe it will demotivate the flooders as they will be no much fun left in flooding. It was a great move to introduce +j, but +q will kill floods along with +j. With +q implemented floods like notice/message/action will be history. Summarize Mass join/joinpart/Notice/Code/Msg flood is the type of flood widely used on dalnet. +j addressed the mass join/join part issue but with the idea of +q we can address the remaining floods.This is a workable idea and if implemented, it would bring us another step closer to eliminate floods completely. My main nick on dalnet is |2|pac, if unclear about my idea plz memo/contact me on that nick. Thanks

1 0

umode modification suggestion
by Tony P. 10 Jul '11

10 Jul '11

One, I don't think there is a warning the person you're messaging isn't going to receive it like with +R. Two, change umode +C to accept messages from users who are on one's watchlist. I mean, the umode +C is to deal with spammers. But it can hurt legit messages, especially if one has friends who don't join the same channel one does.

1 0

Suggestion regarding expiring nick
by Faizan Ahmed 05 Jul '11

05 Jul '11

Dear Concern, I am a happy user of DALnet and quite satisfied with your services. I've been using DALNET since 2000 with my Nick Fair_Friend which recently dropped after 9/10 years registration. Because of which I was quite upset. Here I have a suggestion that if registered nick going to be dropped, User must notify through email regarding expiring nick before a week so that permenant users like me will must come back to avoid expiration of their nicks. Due to some busyness i could not identify my nick and when came back I shocked to see my nick's dropped. THAT REALLY MADE ME UNHAPPY. Hope my suggestion will pe entertained. Best regards Faizan Ahmed

1 0

[PATCH] Support for nick!user@host topics, requires capab NICKIPSTR.
by Kobi Shmueli 01 Jul '11

01 Jul '11

--- include/send.h | 1 + include/struct.h | 2 +- src/channel.c | 41 +++++++++++++++++++++++++++++++++-------- src/send.c | 29 +++++++++++++++++++++++++++++ 4 files changed, 64 insertions(+), 9 deletions(-) diff --git a/include/send.h b/include/send.h index a96adda..eab3766 100644 --- a/include/send.h +++ b/include/send.h @@ -75,6 +75,7 @@ extern void sendto_realops(char *pattern, ...) ATTRIBUTE_PRINTF(1, 2); extern void sendto_non_noquit_servs_butone(aClient *one, char *pattern, ...) ATTRIBUTE_PRINTF(2, 3); extern void sendto_serv_butone(aClient *one, char *pattern, ...) ATTRIBUTE_PRINTF(2, 3); extern void sendto_serv_butone_nickipstr(aClient *one, int flag, char *pattern, ...) ATTRIBUTE_PRINTF(3, 4); +extern void sendto_capab_serv_butone(aClient *one, int include, int exclude, char *pattern, ...) ATTRIBUTE_PRINTF(4, 5); extern void sendto_serv_butone_super(aClient *one, int flag, char *pattern, ...) ATTRIBUTE_PRINTF(3, 4); extern void sendto_wallops_butone(aClient *one, aClient *from, char *pattern, ...) ATTRIBUTE_PRINTF(3, 4); diff --git a/include/struct.h b/include/struct.h index ee705cb..b9c9c87 100644 --- a/include/struct.h +++ b/include/struct.h @@ -1212,7 +1212,7 @@ struct Channel Mode mode; char chname[CHANNELLEN+1]; char topic[TOPICLEN + 1]; - char topic_nick[NICKLEN + 1]; + char topic_nick[NICKLEN + 1 + USERLEN + 1 + HOSTLEN + 1]; time_t topic_time; int users; chanMember* members; diff --git a/src/channel.c b/src/channel.c index 40c14ae..c55ae2b 100644 --- a/src/channel.c +++ b/src/channel.c @@ -3329,14 +3329,32 @@ void send_topic_burst(aClient *cptr) { aChannel *chptr; aClient *acptr; + char *tmpptr; /* Temporary pointer to remove the user@host part from tnick for non-NICKIPSTR servers */ + char tnick[NICKLEN + 1]; /* chptr->topic_nick without the user@host part for non-NICKIPSTR servers */ + int len; /* tnick's length */ if (!(confopts & FLAGS_SERVHUB) || !(cptr->serv->uflags & ULF_NOBTOPIC)) for (chptr = channel; chptr; chptr = chptr->nextch) { if(chptr->topic[0] != '\0') - sendto_one(cptr, ":%s TOPIC %s %s %ld :%s", me.name, chptr->chname, - chptr->topic_nick, (long)chptr->topic_time, - chptr->topic); + { + if(cptr->capabilities & CAPAB_NICKIPSTR) + sendto_one(cptr, ":%s TOPIC %s %s %ld :%s", me.name, chptr->chname, + chptr->topic_nick, (long)chptr->topic_time, + chptr->topic); + else + { + /* This is a non-NICKIPSTR server, we need to remove the user@host part before we send it */ + tmpptr = chptr->topic_nick; + len = 0; + while(*tmpptr && *tmpptr!='!') + tnick[len++] = *(tmpptr++); + tnick[len] = '\0'; + sendto_one(cptr, ":%s TOPIC %s %s %ld :%s", me.name, chptr->chname, + tnick, (long)chptr->topic_time, + chptr->topic); + } + } } if (!(confopts & FLAGS_SERVHUB) || !(cptr->serv->uflags & ULF_NOBAWAY)) @@ -3357,7 +3375,8 @@ void send_topic_burst(aClient *cptr) int m_topic(aClient *cptr, aClient *sptr, int parc, char *parv[]) { aChannel *chptr = NullChn; - char *topic = NULL, *name, *tnick = sptr->name; + char *topic = NULL, *name, *tnick; + char *tmpptr; /* Temporary pointer to remove the user@host part from tnick for non-NICKIPSTR servers */ time_t ts = timeofday; int member; @@ -3427,6 +3446,7 @@ int m_topic(aClient *cptr, aClient *sptr, int parc, char *parv[]) chptr->chname); return 0; } + tnick = make_nick_user_host(sptr->name, sptr->user->username, sptr->user->host); } else { @@ -3437,6 +3457,7 @@ int m_topic(aClient *cptr, aClient *sptr, int parc, char *parv[]) tnick = parv[2]; ts = atoi(parv[3]); } + else tnick = sptr->name; /* ignore old topics during burst/race */ if (!IsULine(sptr) && chptr->topic[0] && chptr->topic_time >= ts) @@ -3451,10 +3472,14 @@ int m_topic(aClient *cptr, aClient *sptr, int parc, char *parv[]) * sends with the topic, so I changed everything to work like that. * -wd */ - sendto_serv_butone(cptr, ":%s TOPIC %s %s %lu :%s", parv[0], - chptr->chname, chptr->topic_nick, - (unsigned long)chptr->topic_time, - chptr->topic); + sendto_capab_serv_butone(cptr, CAPAB_NICKIPSTR, 0, ":%s TOPIC %s %s %lu :%s", parv[0], + chptr->chname, chptr->topic_nick, + (unsigned long)chptr->topic_time, chptr->topic); + if((tmpptr = strchr(tnick, '!'))) + *tmpptr = '\0'; /* Remove the user@host part before we send it to non-NICKIPSTR servers */ + sendto_capab_serv_butone(cptr, 0, CAPAB_NICKIPSTR, ":%s TOPIC %s %s %lu :%s", parv[0], + chptr->chname, chptr->topic_nick, + (unsigned long)chptr->topic_time, chptr->topic); sendto_channel_butserv_me(chptr, sptr, ":%s TOPIC %s :%s", parv[0], chptr->chname, chptr->topic); diff --git a/src/send.c b/src/send.c index 00fcab0..96fde71 100644 --- a/src/send.c +++ b/src/send.c @@ -792,6 +792,35 @@ void sendto_serv_butone_nickipstr(aClient *one, int flag, char *pattern, ...) return; } +/* sendto_capab_serv_butone - Send a message to all servers with "include" capab and without "exclude" capab */ +void sendto_capab_serv_butone(aClient *one, int include, int exclude, char *pattern, ...) +{ + aClient *cptr; + int k = 0; + fdlist send_fdlist; + va_list vl; + DLink *lp; + + va_start(vl, pattern); + for(lp = server_list; lp; lp = lp->next) + { + cptr = lp->value.cptr; + + if ((one==cptr) || + (include && !(cptr->capabilities & include)) || + (exclude && (cptr->capabilities & exclude))) + continue; + + send_fdlist.entry[++k] = cptr->fd; + } + send_fdlist.last_entry = k; + if (k) + vsendto_fdlist(&send_fdlist, pattern, vl); + va_end(vl); + + return; +} + /* * sendto_server_butone * -- 1.7.1.1

1 0

[PATCH 1/4] Added check for Linux to use /dev/urandom instead of /dev/random. BSD /dev/random does not block like it does on Linux.
by Emilio Escobar 01 Jul '11

01 Jul '11

--- src/dh.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/dh.c b/src/dh.c index 889c808..f588aeb 100644 --- a/src/dh.c +++ b/src/dh.c @@ -44,7 +44,11 @@ #ifdef __OpenBSD__ #define RAND_SRC "/dev/arandom" #else -#define RAND_SRC "/dev/random" +#ifdef __linux__ +#define RAND_SRC "/dev/urandom" +#else +#define RAND_SRC "/dev/urandom" +#endif #endif -- 1.7.2.5

1 3

[PATCH] Support for nick!user@host topics, requires capab NICKIPSTR.
by Kobi Shmueli 01 Jul '11

01 Jul '11

--- include/send.h | 1 + include/struct.h | 2 +- src/channel.c | 41 +++++++++++++++++++++++++++++++++-------- src/send.c | 29 +++++++++++++++++++++++++++++ 4 files changed, 64 insertions(+), 9 deletions(-) diff --git a/include/send.h b/include/send.h index a96adda..eab3766 100644 --- a/include/send.h +++ b/include/send.h @@ -75,6 +75,7 @@ extern void sendto_realops(char *pattern, ...) ATTRIBUTE_PRINTF(1, 2); extern void sendto_non_noquit_servs_butone(aClient *one, char *pattern, ...) ATTRIBUTE_PRINTF(2, 3); extern void sendto_serv_butone(aClient *one, char *pattern, ...) ATTRIBUTE_PRINTF(2, 3); extern void sendto_serv_butone_nickipstr(aClient *one, int flag, char *pattern, ...) ATTRIBUTE_PRINTF(3, 4); +extern void sendto_capab_serv_butone(aClient *one, int include, int exclude, char *pattern, ...) ATTRIBUTE_PRINTF(4, 5); extern void sendto_serv_butone_super(aClient *one, int flag, char *pattern, ...) ATTRIBUTE_PRINTF(3, 4); extern void sendto_wallops_butone(aClient *one, aClient *from, char *pattern, ...) ATTRIBUTE_PRINTF(3, 4); diff --git a/include/struct.h b/include/struct.h index ee705cb..b9c9c87 100644 --- a/include/struct.h +++ b/include/struct.h @@ -1212,7 +1212,7 @@ struct Channel Mode mode; char chname[CHANNELLEN+1]; char topic[TOPICLEN + 1]; - char topic_nick[NICKLEN + 1]; + char topic_nick[NICKLEN + 1 + USERLEN + 1 + HOSTLEN + 1]; time_t topic_time; int users; chanMember* members; diff --git a/src/channel.c b/src/channel.c index 40c14ae..c55ae2b 100644 --- a/src/channel.c +++ b/src/channel.c @@ -3329,14 +3329,32 @@ void send_topic_burst(aClient *cptr) { aChannel *chptr; aClient *acptr; + char *tmpptr; /* Temporary pointer to remove the user@host part from tnick for non-NICKIPSTR servers */ + char tnick[NICKLEN + 1]; /* chptr->topic_nick without the user@host part for non-NICKIPSTR servers */ + int len; /* tnick's length */ if (!(confopts & FLAGS_SERVHUB) || !(cptr->serv->uflags & ULF_NOBTOPIC)) for (chptr = channel; chptr; chptr = chptr->nextch) { if(chptr->topic[0] != '\0') - sendto_one(cptr, ":%s TOPIC %s %s %ld :%s", me.name, chptr->chname, - chptr->topic_nick, (long)chptr->topic_time, - chptr->topic); + { + if(cptr->capabilities & CAPAB_NICKIPSTR) + sendto_one(cptr, ":%s TOPIC %s %s %ld :%s", me.name, chptr->chname, + chptr->topic_nick, (long)chptr->topic_time, + chptr->topic); + else + { + /* This is a non-NICKIPSTR server, we need to remove the user@host part before we send it */ + tmpptr = chptr->topic_nick; + len = 0; + while(*tmpptr && *tmpptr!='!') + tnick[len++] = *(tmpptr++); + tnick[len] = '\0'; + sendto_one(cptr, ":%s TOPIC %s %s %ld :%s", me.name, chptr->chname, + tnick, (long)chptr->topic_time, + chptr->topic); + } + } } if (!(confopts & FLAGS_SERVHUB) || !(cptr->serv->uflags & ULF_NOBAWAY)) @@ -3357,7 +3375,8 @@ void send_topic_burst(aClient *cptr) int m_topic(aClient *cptr, aClient *sptr, int parc, char *parv[]) { aChannel *chptr = NullChn; - char *topic = NULL, *name, *tnick = sptr->name; + char *topic = NULL, *name, *tnick; + char *tmpptr; /* Temporary pointer to remove the user@host part from tnick for non-NICKIPSTR servers */ time_t ts = timeofday; int member; @@ -3427,6 +3446,7 @@ int m_topic(aClient *cptr, aClient *sptr, int parc, char *parv[]) chptr->chname); return 0; } + tnick = make_nick_user_host(sptr->name, sptr->user->username, sptr->user->host); } else { @@ -3437,6 +3457,7 @@ int m_topic(aClient *cptr, aClient *sptr, int parc, char *parv[]) tnick = parv[2]; ts = atoi(parv[3]); } + else tnick = sptr->name; /* ignore old topics during burst/race */ if (!IsULine(sptr) && chptr->topic[0] && chptr->topic_time >= ts) @@ -3451,10 +3472,14 @@ int m_topic(aClient *cptr, aClient *sptr, int parc, char *parv[]) * sends with the topic, so I changed everything to work like that. * -wd */ - sendto_serv_butone(cptr, ":%s TOPIC %s %s %lu :%s", parv[0], - chptr->chname, chptr->topic_nick, - (unsigned long)chptr->topic_time, - chptr->topic); + sendto_capab_serv_butone(cptr, CAPAB_NICKIPSTR, 0, ":%s TOPIC %s %s %lu :%s", parv[0], + chptr->chname, chptr->topic_nick, + (unsigned long)chptr->topic_time, chptr->topic); + if((tmpptr = strchr(tnick, '!'))) + *tmpptr = '\0'; /* Remove the user@host part before we send it to non-NICKIPSTR servers */ + sendto_capab_serv_butone(cptr, 0, CAPAB_NICKIPSTR, ":%s TOPIC %s %s %lu :%s", parv[0], + chptr->chname, chptr->topic_nick, + (unsigned long)chptr->topic_time, chptr->topic); sendto_channel_butserv_me(chptr, sptr, ":%s TOPIC %s :%s", parv[0], chptr->chname, chptr->topic); diff --git a/src/send.c b/src/send.c index 00fcab0..96fde71 100644 --- a/src/send.c +++ b/src/send.c @@ -792,6 +792,35 @@ void sendto_serv_butone_nickipstr(aClient *one, int flag, char *pattern, ...) return; } +/* sendto_capab_serv_butone - Send a message to all servers with "include" capab and without "exclude" capab */ +void sendto_capab_serv_butone(aClient *one, int include, int exclude, char *pattern, ...) +{ + aClient *cptr; + int k = 0; + fdlist send_fdlist; + va_list vl; + DLink *lp; + + va_start(vl, pattern); + for(lp = server_list; lp; lp = lp->next) + { + cptr = lp->value.cptr; + + if ((one==cptr) || + (include && !(cptr->capabilities & include)) || + (exclude && (cptr->capabilities & exclude))) + continue; + + send_fdlist.entry[++k] = cptr->fd; + } + send_fdlist.last_entry = k; + if (k) + vsendto_fdlist(&send_fdlist, pattern, vl); + va_end(vl); + + return; +} + /* * sendto_server_butone * -- 1.7.1.1

1 0

[PATCH 1/1] Fixed va_free statements and modified prefix_buffer to use copy of va_list to keep original defined.
by Emilio A. Escobar 01 Jul '11

01 Jul '11

The remaining vsprintf fixes required for 64-bit compatibility. --- src/send.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/send.c b/src/send.c index 00fcab0..ae7b0fa 100644 --- a/src/send.c +++ b/src/send.c @@ -486,8 +486,10 @@ static inline int prefix_buffer(int remote, aClient *from, char *prefix, char *p; /* temp pointer */ int msglen; /* the length of the message we end up with */ int sidx = 1; /* start at offset 1 */ + va_list vl2; /* copy of vl */ *buffer = ':'; + va_copy(vl2, vl); if(!remote && IsPerson(from)) { @@ -526,9 +528,10 @@ static inline int prefix_buffer(int remote, aClient *from, char *prefix, buffer[sidx++] = *p; } - msglen = ircvsprintf(&buffer[sidx], pattern + 3, vl); + msglen = ircvsprintf(&buffer[sidx], pattern + 3, vl2); msglen += sidx; + va_end(vl2); return msglen; } @@ -1453,7 +1456,8 @@ void sendto_prefix_one(aClient *to, aClient *from, char *pattern, ...) sendto_ops("Send message (%s) to %s[%s] dropped from " "%s(Fake Dir)", temp, to->name, to->from->name, from->name); - va_end(vl); + va_end(vl2); + va_end(vl); return; } @@ -1882,7 +1886,7 @@ void sendto_locops(char *pattern, ...) ircsprintf(nbuf, ":%s NOTICE %s :*** LocOps -- %s", me.name, cptr->name, pattern); vsendto_one(cptr, nbuf, vl2); - va_end(vl); + va_end(vl2); } } va_end(vl); -- 1.7.2.5

1 0